Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Server Update endpoint is nullable #1741

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Voice Server Update endpoint is nullable #1741

merged 3 commits into from
Apr 5, 2021

Conversation

Shadorc
Copy link
Contributor

@Shadorc Shadorc commented Jun 13, 2020

Fixes #1739

@jhgg
Copy link
Contributor

jhgg commented Jun 13, 2020

I would drop the "it should be ignored" recommendation and replace with "you should attempt to disconnect from the currently connected voice server, and not attempt to reconnect until a new voice server is allocated" or something to that effect.

@Shadorc
Copy link
Contributor Author

Shadorc commented Jun 13, 2020

Will a new allocated server be notified by a new voice server update event?

BartArys added a commit to kordlib/kord that referenced this pull request Nov 28, 2020
@night night merged commit e887382 into discord:master Apr 5, 2021
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Apr 10, 2021
itohatweb added a commit to discordeno/discordeno that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VOICE_SERVER_UPDATE contains null endpoint
3 participants