Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document role tags #2230

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Document role tags #2230

merged 3 commits into from
Nov 25, 2020

Conversation

vaporoxx
Copy link
Contributor

@vaporoxx vaporoxx commented Nov 9, 2020

@MinnDevelopment
Copy link
Contributor

Has the guild deploy for this happened yet?

@vaporoxx
Copy link
Contributor Author

vaporoxx commented Nov 9, 2020

Not sure, it worked in the few guilds where I could check for role tags so I decided to open this anyway for when the deploy happens.

Copy link
Contributor

@msciotti msciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy is done! LGTM with the 1 nit and I'll merge after.

@vaporoxx vaporoxx requested a review from msciotti November 25, 2020 21:27
| ------------------- | --------- | --------------------------------------------------- |
| bot_id? | snowflake | the id of the bot this role belongs to |
| integration_id? | snowflake | the id of the integration this role belongs to |
| premium_subscriber? | null | whether this is the guild's premium subscriber role |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a weird way for us to pass this value. It's correct! Just weird, lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually mean? If the field is present, it should always be null...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the field is present, it means the role is a premium subscriber role and the value is always null (if present)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's extremely strange - I'd love to hear what the thought behind that was, and what underlying type it actually has (assuming a nullable bool?)

@msciotti msciotti merged commit 7113cee into discord:master Nov 25, 2020
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Nov 26, 2020
BartArys added a commit to kordlib/kord that referenced this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants