-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document role tags #2230
Document role tags #2230
Conversation
Has the guild deploy for this happened yet? |
Not sure, it worked in the few guilds where I could check for role tags so I decided to open this anyway for when the deploy happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy is done! LGTM with the 1 nit and I'll merge after.
| ------------------- | --------- | --------------------------------------------------- | | ||
| bot_id? | snowflake | the id of the bot this role belongs to | | ||
| integration_id? | snowflake | the id of the integration this role belongs to | | ||
| premium_subscriber? | null | whether this is the guild's premium subscriber role | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a weird way for us to pass this value. It's correct! Just weird, lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this actually mean? If the field is present, it should always be null...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the field is present, it means the role is a premium subscriber role and the value is always null (if present)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's extremely strange - I'd love to hear what the thought behind that was, and what underlying type it actually has (assuming a nullable bool?)
#1537