Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ban delete_message_seconds and remove reason #5219

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Document ban delete_message_seconds and remove reason #5219

merged 1 commit into from
Aug 29, 2022

Conversation

advaith1
Copy link
Contributor

Updated banning docs:

  • Added delete_message_seconds
  • Marked delete_message_days as deprecated
  • Removed reason, which was removed in v10

@advaith1 advaith1 mentioned this pull request Jul 20, 2022
Merged
@Lulalaby
Copy link
Contributor

reason is replaced with the X-Auditlog-Reason Header right?

@advaith1 advaith1 mentioned this pull request Jul 21, 2022
Merged
@ooliver1
Copy link

reason is replaced with the X-Auditlog-Reason Header right?

As the v10 changelog says, yes

@splatterxl
Copy link
Contributor

Does the new field accept an arbitrary number of seconds or is it a predefined list?

@advaith1
Copy link
Contributor Author

any number in the range

@VelvetToroyashi VelvetToroyashi mentioned this pull request Jul 21, 2022
Merged
@TAG-Epic TAG-Epic mentioned this pull request Jul 21, 2022
Open
@SQKo SQKo mentioned this pull request Jul 22, 2022
Closed
5 tasks
@DonovanDMC DonovanDMC mentioned this pull request Jul 22, 2022
Closed
@DonovanDMC
Copy link
Contributor

Testing this out, it seems to be overreaching. With 4 messages spaced out about 2 minutes each, a delete_message_seconds value of 60 deletes all 4. Tested in both v9 & v10, same results in both. Is this not fully ready yet, or is there some invisible rounding happening behind the scenes?

@SQKo SQKo mentioned this pull request Jul 22, 2022
Merged
@onerandomusername onerandomusername mentioned this pull request Jul 26, 2022
Closed
@Middledot Middledot mentioned this pull request Aug 9, 2022
Merged
8 tasks
@sebm253 sebm253 mentioned this pull request Aug 16, 2022
Merged
@shiftinv shiftinv mentioned this pull request Aug 16, 2022
Merged
8 tasks
@infinitestory infinitestory merged commit 7e3e3a3 into discord:main Aug 29, 2022
@MinnDevelopment MinnDevelopment mentioned this pull request Aug 29, 2022
Merged
6 tasks
@advaith1 advaith1 deleted the delete-message-seconds branch August 29, 2022 22:37
@ooliver1 ooliver1 mentioned this pull request Aug 30, 2022
Closed
@lukellmann lukellmann mentioned this pull request Aug 30, 2022
Merged
@RealYusufIsmail RealYusufIsmail mentioned this pull request Aug 31, 2022
Closed
@itohatweb itohatweb mentioned this pull request Sep 1, 2022
Closed
itohatweb added a commit to twilight-rs/twilight that referenced this pull request Sep 1, 2022
@itohatweb
feat(http,validate): add create guild ban delete message seconds
9425a73 
Additionally deprecated delete message days related functionality.

Reference:discord/discord-api-docs#5219
@itohatweb itohatweb mentioned this pull request Sep 1, 2022
Merged
@B1ue-Dev B1ue-Dev mentioned this pull request Sep 8, 2022
Merged
9 tasks
@1NieR 1NieR mentioned this pull request Dec 21, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@advaith1 @Lulalaby @ooliver1 @splatterxl @DonovanDMC @infinitestory