Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RPC): types #1200

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(RPC): types #1200

wants to merge 21 commits into from
+6,246 −0

Conversation

OfficialSirH
Copy link
Contributor

@OfficialSirH OfficialSirH commented Jan 26, 2025 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Closes #645
Closes #529

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:48pm

@OfficialSirH @sdanialraza
feat: rpc types
c093891 
Co-authored-by: Danial Raza <[email protected]>
@OfficialSirH OfficialSirH changed the title feat: RPC Types feat(RPC): types Feb 13, 2025
@OfficialSirH OfficialSirH marked this pull request as ready for review February 25, 2025 00:20
@OfficialSirH OfficialSirH requested a review from a team as a code owner February 25, 2025 00:20
@OfficialSirH OfficialSirH requested a review from a team as a code owner February 25, 2025 00:20
@Jiralite Jiralite mentioned this pull request Feb 25, 2025
Closed
Jiralite
Jiralite previously requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please go through all the documentation and capitalise the first letter!
  2. "rpc" should be capitalised in the documentation everywhere. Would you mind doing that?
  3. When you add hyperlinks, do so like {@link <link> | <display_text>} instead of [<text>](<link>)

@OfficialSirH @Jiralite
Update rpc/v10.ts
209291b 
Co-authored-by: Jiralite <[email protected]>
sdanialraza
sdanialraza requested changes Feb 26, 2025
View reviewed changes
@sdanialraza sdanialraza requested a review from Jiralite February 26, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@sdanialraza sdanialraza sdanialraza approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@Jiralite Jiralite Awaiting requested review from Jiralite

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
topic:payloads topic:rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OfficialSirH @Jiralite @almeidx @sdanialraza