Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: components v2 #10781

Open
wants to merge 4 commits into
base: v14
Choose a base branch
from
Open

feat: components v2 #10781

wants to merge 4 commits into from

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Feb 23, 2025

Please describe the changes this PR makes and why it should be merged:

Implements Components v2 into mainlib v14.
Only raw JSON data is supported yet, builders not included.

Depends on

Will need a builders v1 release too, since that discord-api-types PR is breaking and some types builders use have been renamed. But since builders v1 is on another branch it has to be another PR.

TODO: uncomment the currently commented type tests that fail because of wrong builders version once builders PR is done, merged and released; also bump builders version to that release.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:27pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:27pm

@Qjuh Qjuh marked this pull request as ready for review February 24, 2025 08:55
@Qjuh Qjuh requested review from a team and iCrawl as code owners February 24, 2025 08:55
@Qjuh Qjuh requested review from vladfrangu, kyranet and SpaceEEC and removed request for a team February 24, 2025 08:55
@Qjuh Qjuh added the blocked label Feb 24, 2025
@Qjuh Qjuh force-pushed the mainlib-v14/v2-components branch from e6541fb to 8835fd6 Compare February 24, 2025 12:06
imnaiyar

This comment was marked as resolved.

@Qjuh Qjuh requested a review from imnaiyar February 27, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

2 participants