Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Integration): Add Integration#roles getter #4630

Closed
wants to merge 1 commit into from
Closed

feat(Integration): Add Integration#roles getter #4630

wants to merge 1 commit into from

Conversation

vaporoxx
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Integration#role currently only returns a single role, however an integration can manage multiple ones. This getter filters the guild's roles by their integration id to return all roles instead.

Consideration

Because the role's tags (see below) aren't guaranteed to be on the object, it's more reliable to use Integration#role. This could be shown in an info/warn tag if Discord is too lazy to fix it before documenting it.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • Draft PR: This requires feat(Role): role tags #4628 to be merged to make use of the Role#tags property

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants