Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite Ronny Vedrilla to team. #147

Closed
carltongibson opened this issue Jan 3, 2024 · 28 comments
Closed

Invite Ronny Vedrilla to team. #147

carltongibson opened this issue Jan 3, 2024 · 28 comments

Comments

@carltongibson
Copy link
Contributor

I'd like to propose adding Ronny @GitRon to the team for crispy-tailwind.

I can vouch for Ronny personally. He's a lovely person. And crispy-tailwind could do with more bandwidth.

@smithdc1 I don't believe you're actively using tailwind right? Whilst I am, I'm not currently using crispy for that (as part of my experiment into What Now? given the Django 4.x+ forms changes). Ronny is going both, and is well placed to take the lead here.

Whilst we're here, I'd state my thoughts on the scope/goals:

  • Keep it small — it's a demonstration of what you can do, and a starting point, not an always solution.
  • Link to and document other things in How-Tos
  • Encourage folks to override what they want to in their own projects.
@smithdc1
Copy link
Member

smithdc1 commented Jan 4, 2024

Hi @carltongibson & @GitRon, Happy New Year to you both.

This is great. 🎉 The project could certainly do with more bandwidth, also my knowledge of Tailwind is pretty basic.

Carlton -- Are you able to help with the invite? I had a look and got a bit lost on what I should do. It seems more complicated than last time I looked!

@carltongibson
Copy link
Contributor Author

OK, done, I think 😅

I invited Ronny to the crispy forms core team, added access to all the crispy repos there, and set the Triage role (which should allow close/merging/... PRs and such.)

@GitRon Welcome aboard! Go! 🎉 Shout if you want input, or if the permissions aren't right or... — Both @smithdc1 and I watch the repos say if you need anything. 🎁

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

Thanks, guys! It's the first time for me maintaining a package together with other people!

Hence I have some questions:

  • Am I supposed to merge PRs as well?
  • Who's doing a release and when? Merged branches are nice but if it's not released, it basically didn't happen.

@carltongibson
Copy link
Contributor Author

Yep @GitRon merge 'em!

If you can do things like change notes and what not, we can check over and do the release (but so can you: we just need to get the permissions lined up)

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

Good point! Forgot about the change notes in the last ticket. Will add it for my current PR.

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

OK, once #146 is merged, I'd suggest a release. The last one was ages ago and @smithdc1 did already some changes to the metadata in October which never saw the light of day 😅

Are you ok with this?

@carltongibson
Copy link
Contributor Author

Yep, sounds good.

If you get it ready, or as close as you can, then that's amazing. It really helps.

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

The PR is merged. Nothing open from my side 🙂

Supplemental: Should we go to version 1.0? The package might be a little buggy but I still think it's stable enough for 1.x

@smithdc1
Copy link
Member

smithdc1 commented Jan 4, 2024

How about switching to CalVer? 🤔

@carltongibson
Copy link
Contributor Author

carltongibson commented Jan 4, 2024

Yeah! +1 for CalVer.

I personally favour two digit year, plus number of release in year. So 24.1 it would be.

(Some folks like the extra month... 24.1.1 but it seems a bit much to me unless you're like Ubuntu.)

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

Hm, I think it's great for certain packages like my meta-package-updater because it doesn't contain any code.

I like semVer a lot because when I update the package I know what to expect. Bugfix release? No need to worry. Major release? Let's have a deep dive into the changelog. CalVer Doesn't provide that.

My 5c on the topic 🙂

@justinmayer
Copy link
Contributor

justinmayer commented Jan 4, 2024

I was going to suggest that I volunteer to help out by automating releases via AutoPub, but I don't believe it supports CalVer (yet). 😊

@carltongibson
Copy link
Contributor Author

My jaded take on breaking changes is that they're all breaking changes. 😅 Folks complain no matter what. SemVer writes checks poor maintainers can't cash: let 'em read the release notes.

(This may apply all the more for template heavy packages, where folks write CSS/JS to match the HTML exactly...)

Happy to go with the consensus though.

@justinmayer
Copy link
Contributor

Folks will indeed complain no matter what, but I'm not sure that's a good justification for CalVer. I prefer SemVer because it at least conveys some information regarding what lies within, whereas CalVer feels to me like an unnecessary capitulation.

SemVer is a guide for users and not a promise, and therefore to me it's not akin to writing checks doomed to bounce. As for folks who have an expectation that SemVer is a promise, I say let those misguided folks complain as much as they like.

Just my take on this topic, of course. 😊

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

In general, I agree with @justinmayer but Carlton has a point in this case:

(This may apply all the more for template heavy packages, where folks write CSS/JS to match the HTML exactly...)

@carltongibson
Copy link
Contributor Author

carltongibson commented Jan 4, 2024

@justinmayer Can we get you to DjangoCon and we can wrestle for it 😜

🎁

...some information...

Conversely I often find when was this release to be more insightful than a major version number, but yes, there are different points to make.

I'm not hung up. +1 to the majority view

@GitRon
Copy link
Contributor

GitRon commented Jan 4, 2024

I've already bought tickets 🙃

@GitRon
Copy link
Contributor

GitRon commented Jan 9, 2024

The discussion about having a release ASAP got a little bit derailed 😅

If @justinmayer could to the changes for the auto-versioning reasonably soon, I'd take this as a killer argument pro semVer. If he can't do that (which is of course perfectly fine!), I'd put up a vote between calVer and semVer and do a 0.6.0 release so we get all the new stuff shipped out-

Can we agree on that roadmap? 🙂

@carltongibson
Copy link
Contributor Author

Don't let the version number delay you! (Not that much hangs on it 😅)

@GitRon
Copy link
Contributor

GitRon commented Jan 9, 2024

I think I can't do the release, right? The question is: Who can? 😅

@carltongibson
Copy link
Contributor Author

carltongibson commented Jan 9, 2024

@smithdc1 can. But you can get it close 😉.

(The actual twine upload bit is the least of it... — but maybe we can get you added on PyPI too.)

@smithdc1
Copy link
Member

smithdc1 commented Jan 9, 2024

https://github.com/django-crispy-forms/crispy-tailwind/blob/main/.github%2Fworkflows%2Fpublish.yml

We've a workflow setup. It's "just" a matter of creating a GH Release. I'm happy to do that, just need to make sure version number is updated etc.

@justinmayer
Copy link
Contributor

If @justinmayer could to the changes for the auto-versioning reasonably soon, I'd take this as a killer argument pro semVer. If he can't do that (which is of course perfectly fine!), I'd put up a vote between calVer and semVer and do a 0.6.0 release so we get all the new stuff shipped out

I would be more than happy to set that up. The configuration I would recommend would include publishing via PyPI's new Trusted Publisher system, and it also would automatically create the GitHub Release as part of the release process.

@GitRon
Copy link
Contributor

GitRon commented Jan 9, 2024

@smithdc1 What do I have to do? Just update the version number somewhere in the code?

@justinmayer I'd be happy about a PR, sounds like a neat solution. I guess the others agree?

@smithdc1
Copy link
Member

smithdc1 commented Jan 9, 2024

@GitRon https://github.com/django-crispy-forms/crispy-tailwind/blob/main/crispy_tailwind%2F__init__.py

Just here I think.

Thanks for all your efforts here!

GitRon added a commit to GitRon/crispy-tailwind that referenced this issue Jan 9, 2024
GitRon added a commit to GitRon/crispy-tailwind that referenced this issue Jan 9, 2024
@GitRon
Copy link
Contributor

GitRon commented Jan 9, 2024

Hi @smithdc1 - I've created a PR with the version dump and updated the changelog: #148

Do you need anything else?

GitRon added a commit to GitRon/crispy-tailwind that referenced this issue Jan 9, 2024
GitRon added a commit to GitRon/crispy-tailwind that referenced this issue Jan 9, 2024
GitRon added a commit that referenced this issue Jan 9, 2024
* #147: Version bump

* #147: Changelog

* #147: Updated classifier

* #147: Updated codecov in pipeline
@GitRon
Copy link
Contributor

GitRon commented Jan 9, 2024

@smithdc1 Code has been merged, you can do the release now I guess 😊

GitRon added a commit to GitRon/crispy-tailwind that referenced this issue Jan 9, 2024
@smithdc1
Copy link
Member

smithdc1 commented Jan 9, 2024

Thank you @GitRon ! ❤️

https://pypi.org/project/crispy-tailwind/1.0.0/ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants