New: Add parameter for a custom encoder #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a parameter to supply a custom JSON encoder for the JSON interface.
To avoid installing an extra dependency, a supplied test change simply changes it to check the default encoder. However, this has been tested locally with the ujson module and works fine:
solr_conn = pysolr.Solr("http://localhost:8983/solr/my-core", decoder=ujson, encoder=ujson)
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 94.25% 94.26%
=======================================
Files 7 7
Lines 1340 1342 +2
=======================================
+ Hits 1263 1265 +2
Misses 77 77
Continue to review full report at Codecov.
|
acdha
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a parameter to supply a custom JSON encoder for the JSON interface.
To avoid installing an extra dependency, a supplied test change simply changes it to check the default encoder. However, this has been tested locally with the ujson module and works fine:
solr_conn = pysolr.Solr("http://localhost:8983/solr/my-core", decoder=ujson, encoder=ujson)