Fix doc and superfluous inheritance

dmlc · Jul 1, 2018 · d3dde28 · d3dde28
1 parent 276d89e
commit d3dde28
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/gluonnlp/embedding/token_embedding.py b/gluonnlp/embedding/token_embedding.py
@@ -480,8 +480,21 @@ def unknown_autoextend(self):
 
         return self._unknown_autoextend
 
-    def __contains__(self, x):
-        return x in self._token_to_idx
+    def __contains__(self, token):
+        """Check if token is known.
+
+        Parameters
+        ----------
+        token : str
+            A token.
+
+        Returns
+        -------
+        bool:
+            Return True if the token is known. A token is known if it has been
+            assigned an index and vector.
+        """
+        return token in self._token_to_idx
 
     def __eq__(self, other):
         if isinstance(other, TokenEmbedding):

diff --git a/gluonnlp/model/train/embedding.py b/gluonnlp/model/train/embedding.py
@@ -84,7 +84,7 @@ def __getitem__(self, tokens):
         raise NotImplementedError
 
 
-class SimpleEmbeddingModel(EmbeddingModel, Block):
+class SimpleEmbeddingModel(EmbeddingModel):
     """A trainable embedding model.
 
     This class is a simple wrapper around the mxnet.gluon.nn.Embedding. It