This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Move progress writter into backend(s) #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
aci
api
Signed-off-by: Nicolas De Loof <[email protected]>
mat007
approved these changes
Jun 3, 2021
Comment on lines
+63
to
+68
| if err != nil { | ||
| return err | ||
| } | ||
| if !confirm { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
nit: could be
Suggested change
| if err != nil { | |
| return err | |
| } | |
| if !confirm { | |
| return nil | |
| } | |
| if err != nil || !confirm { | |
| return err | |
| } |
lorenrh
reviewed
Jun 3, 2021
…arget Signed-off-by: Nicolas De Loof <[email protected]>
lorenrh
approved these changes
Jun 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
moved
progress.Runto the backends, to offer more flexibility(long term plan is to get
Upimplemented by local backend)(not mandatory) A picture of a cute animal, if possible in relation with what you did
