This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thyarles
approved these changes
May 15, 2023
Signed-off-by: Nicolas De Loof <[email protected]>
431c125
to
53da0fe
Compare
hyu
reviewed
May 17, 2023
Could we also add to this PR the banner for docs? We pull in some of the pages (shown in the screenshot) into the docs repo but the banner needs to be added here. Can we add:
This will then render as an |
milas
approved these changes
May 18, 2023
Co-authored-by: Han Yu <[email protected]> Signed-off-by: Milas Bowman <[email protected]>
This was referenced May 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docker.atlassian.net/browse/ENV-189
What I did
added a deprecation notice when compose-cli is used with a non-default context type
(not mandatory) A picture of a cute animal, if possible in relation with what you did