Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

cli: deprecation notice #2245

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 15, 2023

https://docker.atlassian.net/browse/ENV-189

What I did
added a deprecation notice when compose-cli is used with a non-default context type

$ docker context create ecs toto
Cloud integration is DEPRECATED. Read more on https://docs.docker.com/cloud/ecs-integration/
? Create a Docker context using:  [Use arrows to move, type to filter]
..

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@ndeloof ndeloof requested review from glours and milas May 15, 2023 13:12
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof force-pushed the deprecation_notice branch from 431c125 to 53da0fe Compare May 16, 2023 13:51
@aevesdocker
Copy link
Contributor

aevesdocker commented May 18, 2023

Could we also add to this PR the banner for docs? We pull in some of the pages (shown in the screenshot) into the docs repo but the banner needs to be added here.

image

Can we add:

>**Important**
>
>Docker Compose's integration for ECS and ACI is retiring in November 2023.
{: .important}

This will then render as an Important callout in the docs

Co-authored-by: Han Yu <[email protected]>
Signed-off-by: Milas Bowman <[email protected]>
@milas milas force-pushed the deprecation_notice branch from 91dfb10 to 92edf30 Compare May 18, 2023 14:33
@milas milas changed the title deprecation notice cli: deprecation notice May 18, 2023
@milas milas merged commit 9b21f9a into docker-archive:main May 18, 2023
@ndeloof ndeloof deleted the deprecation_notice branch May 20, 2023 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants