Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover passenger references #339

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 27, 2024

Support for Passenger was removed in 5.0+, and all older versions are now gone/EOL so this code is reasonable to remove.

Technically, this was the only official usage of tini in the image, so we could make an argument for removing that as well, but maybe it's worth keeping in since it is likely useful for a lot of the strange things that Redmine might do for users who might need it?

Support for Passenger was removed in 5.0+, and all older versions are now gone/EOL so this code is reasonable to remove.
@yosifkit yosifkit merged commit ec4b14e into docker-library:master Jun 27, 2024
7 checks passed
@yosifkit yosifkit deleted the leftover-passengers branch June 27, 2024 22:06
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 28, 2024
Changes:

- docker-library/redmine@ec4b14e: Merge pull request docker-library/redmine#339 from infosiftr/leftover-passengers
- docker-library/redmine@7498e9c: Remove leftover `passenger` references
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Sep 30, 2024
Changes:

- docker-library/redmine@45af1fd: Update `generate-stackbrew-library.sh` to support `BASHBREW_LIBRARY` for easier cascading updates
- docker-library/redmine@23cb85e: Update to actions/checkout@v4 🙃
- docker-library/redmine@ec4b14e: Merge pull request docker-library/redmine#339 from infosiftr/leftover-passengers
- docker-library/redmine@7498e9c: Remove leftover `passenger` references
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 4, 2024
Changes:

- docker-library/redmine@47d9994: Update 5.1 to 5.1.4
- docker-library/redmine@dd8cf6b: Update 5.0 to 5.0.10
- docker-library/redmine@45af1fd: Update `generate-stackbrew-library.sh` to support `BASHBREW_LIBRARY` for easier cascading updates
- docker-library/redmine@23cb85e: Update to actions/checkout@v4 🙃
- docker-library/redmine@ec4b14e: Merge pull request docker-library/redmine#339 from infosiftr/leftover-passengers
- docker-library/redmine@7498e9c: Remove leftover `passenger` references
@laf0rge
Copy link

laf0rge commented Jan 9, 2025

note that https://hub.docker.com/_/redmine also still talks about phusion passenger in the "alternate web server" section.

I personally am rather sad that passenger was deprecated as a variant. Ever since I had to switch to puma, the system load has increased significantly :(

@tianon
Copy link
Member Author

tianon commented Jan 10, 2025

Good catch, thanks for the heads up -- I'll send a PR to remove that section.

You can find a tiny bit more in #261 where we decided to stop officially building the variant, but as noted there, it wasn't ever really well supported, and was a constant source of upgrade issues, so isn't something we can maintain. That being said, what we had previously is probably a reasonable place to start if someone wanted to try and build something FROM our images that included Passenger again for their own purposes:

https://github.com/docker-library/redmine/blob/cc904a5f85eb1bfd99af68c0ea3f1e5aeb5d5554/4.2/passenger/Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants