-
Notifications
You must be signed in to change notification settings - Fork 176
Bump buildx and fix file finalizer breaking the stdout fix #779
Conversation
@ulyssessouza is this the only change in the fork? ulyssessouza/buildx@5941345 |
@thaJeztah In buildx, yes. But there is another fork. The The intent of this PR is first to validate the approach. |
549f183
to
3411212
Compare
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
=========================================
- Coverage 70.13% 70.03% -0.1%
=========================================
Files 67 67
Lines 3676 3684 +8
=========================================
+ Hits 2578 2580 +2
- Misses 753 759 +6
Partials 345 345
Continue to review full report at Codecov.
|
Thanks for clarifying; yes we should avoid forks if possible |
I like the approach of offering a "consumer" counterpart for a PR to upstream project, which helps better unterstand the needs and if fix is actually relevant. |
123fd39
to
278c050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
278c050
to
8dfef25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulyssessouza I wonder if it's ok that so many dependencies were updated? 🤔
@silvin-lubecki After reviewing, that looks like it's a side-effect of the bumps on buildx and containerd. |
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: ulyssessouza <[email protected]>
8dfef25
to
864442b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
Replaced os.File for an interface in
containerd/console
(ulyssessouza/console@f652dc3) so that can be used bydocker/buildx
(ulyssessouza/buildx@5941345) anddocker/app
- How I did it
Fork and override of the repos in
Gopkg.toml
- How to verify it
Check that the broken output fix still working by repeating a
docker app build
exhaustively.- Description for the changelog
Use a file interface from
containerd/console
to pass to buildx's printer- A picture of a cute animal (not mandatory)
