Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]#972 when 'logo' is set, 'name' is not set correctly inside the 'alt' as same as without 'logo' set. #974

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Dec 7, 2019

Summary
fixes #972
What kind of change does this PR introduce? (check at least one)
when 'logo' is set, 'name' is not set correctly inside the 'alt.
fix, make the 'name' parsed the same as without 'logo' set.

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
when logo is set, the name can't be parsed correctly to set in alt as same as without logo set.
eg:
the index.html

...
    maxLevel: 4,
      subMaxLevel: 2,
      name: **look the test case below**,
      logo:'https://koy.example.com/test.jpg'
  • name: 'koy test'
    the current :
<img alt="koy"  test  src="https://koy.example.com/test.jpg">

the fix:

<img alt="koy test"  src="https://koy.example.com/test.jpg">

  • name: 'koy test"'
    the current :
<img alt="koy"  test  src="https://koy.example.com/test.jpg">

the fix:

<img alt="koy test""  src="https://koy.example.com/test.jpg">

...

  • DO NOT include files inside lib directory.

@anikethsaha
Copy link
Member

Thanks for the details Explanation. WIll take a look soon 👍

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks 👍

@anikethsaha anikethsaha merged commit 1622578 into docsifyjs:develop Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When 'logo' is set, 'name' is not escaped properly inside the 'alt' field.
2 participants