Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverse side of RefOne is no longer included in change set #1266

Closed
wants to merge 2 commits into from
Closed

Inverse side of RefOne is no longer included in change set #1266

wants to merge 2 commits into from

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Nov 4, 2015

Fixes #817

@malarzm malarzm added the Task label Nov 4, 2015
@malarzm malarzm changed the title Added passing test for #817 Added failing test for #817 Nov 4, 2015
@malarzm malarzm added Bug and removed Task labels Nov 4, 2015
@malarzm malarzm added this to the 1.0.x milestone Nov 4, 2015
@malarzm malarzm changed the title Added failing test for #817 Inverse side of RefOne is no longer included in change set Dec 15, 2015
@malarzm malarzm changed the title Inverse side of RefOne is no longer included in change set [WIP] Inverse side of RefOne is no longer included in change set Dec 15, 2015
@malarzm
Copy link
Member Author

malarzm commented Dec 15, 2015

Marked as WIP because there are 2 strange things happening if

  1. inverse side checks are removed from PersistenceBuilder
  2. inverse side checks are not done by UnitOfWork::computeAssociationChanges

and I think it's worth ironing this out

@malarzm malarzm changed the title [WIP] Inverse side of RefOne is no longer included in change set Inverse side of RefOne is no longer included in change set Dec 16, 2015
@malarzm
Copy link
Member Author

malarzm commented Dec 16, 2015

  1. Fixed
  2. This is happening because this test uses this inverse side collection to cascade persist. Even if we'd think this shouldn't be allowed I wouldn't change that in a bugfix release

@malarzm malarzm modified the milestones: 1.0.5, 1.0.x Dec 20, 2015
@alcaeus
Copy link
Member

alcaeus commented Dec 23, 2015

Merged manually into 1.0.x branch in 790110e.

@alcaeus alcaeus closed this Dec 23, 2015
@malarzm malarzm deleted the test-gh817 branch February 13, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@malarzm @alcaeus