Fix for fatal exception if persisted collection was unserialized #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new MongoDBException('Specifying targetDocument is required for the ClassMetadata to be obtained.'); | ||
| switch (true) { | ||
| case (! empty($this->typeClass)): | ||
| return $this->typeClass; |
There was a problem hiding this comment.
Now I'm thinking about this there's no point in remembering $this->typeClass (and doing so may lead to edge case if somebody would call setOwner with other mapping), I'll remove it later today
Updated exception message if no document manager is associated with PersistentCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds up on @notrix PR #1390 and changes way
typeClassis obtained to prevent duplicating code