Skip empty $match from pipeline builder
#2740
Open
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Mar 3, 2025
| @@ -33,7 +33,7 @@ public function __construct(Builder $builder) | |||
| * @return array<string, mixed> | |||
| * @phpstan-return StageExpression | |||
| */ | |||
| abstract public function getExpression(): array; | |||
| abstract public function getExpression(): ?array; | |||
There was a problem hiding this comment.
Classes extending this can still restrict the return type.
jmikola
reviewed
Mar 3, 2025
| $pipeline = []; | ||
| foreach ($this->stages as $stage) { | ||
| $stage = $stage->getExpression(); | ||
| if (! $stage) { |
There was a problem hiding this comment.
Would this be better off as an explicit null check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't send an unnecessary stage to the server.
Might be considered as a breaking change is someone manipulate the generated pipeline.