Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RepositoryFactory [#891] #892

Merged
merged 1 commit into from
Mar 28, 2015
Merged

Added RepositoryFactory [#891] #892

merged 1 commit into from
Mar 28, 2015

Conversation

hilobok
Copy link
Contributor

@hilobok hilobok commented May 30, 2014

Added RepositoryFactory in the same way as in ORM and PHPCR. It will give the ability to inject additional services or parameters into Repository.

@jmikola jmikola added this to the 1.0.0-BETA12 milestone Jun 5, 2014
@jmikola jmikola added the feature label Jun 5, 2014
@jmikola
Copy link
Member

jmikola commented Jun 5, 2014

Thanks for the contribution! PRs bringing things up to speed with the other Doctrine projects are always appreciated. I'll take a look at this for the next release.

@jmikola jmikola mentioned this pull request Jun 5, 2014
@jmikola jmikola modified the milestones: 1.0.0-BETA12, 1.0.0-BETA13 Feb 24, 2015
@jwage
Copy link
Member

jwage commented Mar 28, 2015

👍

jwage added a commit that referenced this pull request Mar 28, 2015
@jwage jwage merged commit fb2010c into doctrine:master Mar 28, 2015
@atrauzzi
Copy link

Just so I understand correctly: This would make it so that I could make a RepositoryFactory subclass that uses my framework's DI to supply the resultant instance?

@malarzm
Copy link
Member

malarzm commented Apr 21, 2015

@atrauzzi: Yes

@atrauzzi
Copy link

🎉 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants