Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect gas limit config in eth_gasPrice endpoint #170

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

DarianShawn
Copy link
Collaborator

Description

The PR uses gas limit as the basic gas price in the eth_gasPrice endpoint.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@DarianShawn DarianShawn added the feature New update to Dogechain label Sep 17, 2022
@DarianShawn DarianShawn added this to the Release 1.2.0 milestone Sep 17, 2022
@DarianShawn DarianShawn self-assigned this Sep 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #170 (d5eacff) into dev (e56d55f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #170      +/-   ##
==========================================
- Coverage   51.43%   51.39%   -0.05%     
==========================================
  Files         113      113              
  Lines       16830    16839       +9     
==========================================
- Hits         8657     8654       -3     
- Misses       7436     7446      +10     
- Partials      737      739       +2     
Impacted Files Coverage Δ
jsonrpc/dispatcher.go 54.72% <100.00%> (+1.05%) ⬆️
jsonrpc/eth_endpoint.go 71.36% <100.00%> (-0.19%) ⬇️
jsonrpc/jsonrpc.go 19.67% <100.00%> (+2.72%) ⬆️
network/server_discovery.go 73.88% <0.00%> (-7.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@abrahamcruise321 abrahamcruise321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@abrahamcruise321 abrahamcruise321 merged commit cf53f77 into dev Sep 19, 2022
@abrahamcruise321 abrahamcruise321 deleted the feature/txpool-use-estimate-gas-price branch September 19, 2022 02:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants