-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion template enhancements #412
Merged
agubler
merged 14 commits into
dojo:master
from
agubler:assertion-template-enhancements
Jun 25, 2019
Merged
Assertion template enhancements #412
agubler
merged 14 commits into
dojo:master
from
agubler:assertion-template-enhancements
Jun 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and getProperties
matt-gadd
approved these changes
Jun 25, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: testing
Testing
breaking change
Indicates the issue/pull request would result in a breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Refines the assertion template API, providing additional helper APIs and changes one API to clarify the functionality.
Adds primitive for ignoring widgets during the assertion, useful for lists where there is no need to assert every single item.
Assertion Template Enhancements
API's changed:
(this #247 (comment) came back to haunt me*)
*Actually @matt-gadd 😄
API's added:
New Assertion Template primitive:
Supersedes #314 fixing the conflicts and unit tests on IE