Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure childDomWrapperId is available to insert nodes in the correct order #642

Merged
merged 2 commits into from
Jan 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/core/vdom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1220,10 +1220,15 @@ export function renderer(renderer: () => RenderResult): Renderer {
const nextSibling = _wrapperSiblingMap.get(searchNode);
if (nextSibling) {
let domNode = nextSibling.domNode;
if ((isWNodeWrapper(nextSibling) || isVirtualWrapper(nextSibling)) && nextSibling.childDomWrapperId) {
const childWrapper = _idToWrapperMap.get(nextSibling.childDomWrapperId);
if (childWrapper && !isBodyWrapper(childWrapper)) {
domNode = childWrapper.domNode;
if (isWNodeWrapper(nextSibling) || isVirtualWrapper(nextSibling)) {
if (!nextSibling.childDomWrapperId) {
nextSibling.childDomWrapperId = findDomNodeOnParentWrapper(nextSibling);
}
if (nextSibling.childDomWrapperId) {
const childWrapper = _idToWrapperMap.get(nextSibling.childDomWrapperId);
if (childWrapper && !isBodyWrapper(childWrapper)) {
domNode = childWrapper.domNode;
}
}
}
if (domNode && domNode.parentNode) {
Expand Down Expand Up @@ -2043,16 +2048,14 @@ export function renderer(renderer: () => RenderResult): Renderer {
return processResult;
}

function setDomNodeOnParentWrapper(id: string) {
let wrapper = _idToWrapperMap.get(id)!;
let children = [...(_idToChildrenWrappers.get(id) || [])];
function findDomNodeOnParentWrapper(wrapper: DNodeWrapper): string | undefined {
let children = [...(_idToChildrenWrappers.get(wrapper.id) || [])];
let child: DNodeWrapper | undefined;
while (children.length && !wrapper.domNode) {
child = children.shift();
if (child) {
if (child.domNode) {
wrapper.childDomWrapperId = child.id;
break;
return child.id;
}
let nextChildren = _idToChildrenWrappers.get(child.id);
if (nextChildren) {
Expand All @@ -2062,6 +2065,13 @@ export function renderer(renderer: () => RenderResult): Renderer {
}
}

function setDomNodeOnParentWrapper(id: string) {
let wrapper = _idToWrapperMap.get(id);
if (wrapper) {
wrapper.childDomWrapperId = findDomNodeOnParentWrapper(wrapper);
}
}

function _createDom({ next }: CreateDomInstruction): ProcessResult {
const parentDomNode = findParentDomNode(next)!;
const isVirtual = isVirtualWrapper(next);
Expand Down
55 changes: 55 additions & 0 deletions tests/core/unit/vdom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1499,6 +1499,61 @@ jsdomDescribe('vdom', () => {
assert.strictEqual(div.outerHTML, '<div><div><foobar></foobar><baz></baz><qux></qux></div></div>');
});

it('should insert widgets in the correct position when the nested widgets domNode is not initially rendered', () => {
const root = document.createElement('div');

let invalidateApp: any[] = [];
let renderA = false;
let renderB = false;

class VirtualFoo extends WidgetBase<{ render: boolean }> {
constructor() {
super();
invalidateApp.push(() => {
this.invalidate();
});
}

render() {
return w(Foo, {
key: this.properties.key,
render: this.properties.key === 'a' ? renderA : renderB
});
}
}

class Foo extends WidgetBase<{ render: boolean }> {
render() {
if (this.properties.render) {
return v('div', [`${this.properties.key}`]);
}
return null;
}
}

class App extends WidgetBase {
render() {
return v('div', [
w(VirtualFoo, { key: 'a', render: renderA }),
w(VirtualFoo, { key: 'b', render: renderB })
]);
}
}

const r = renderer(() => w(App, {}));
r.mount({ domNode: root });
resolvers.resolve();
assert.strictEqual(root.innerHTML, '<div></div>');
renderB = true;
invalidateApp[1]();
resolvers.resolve();
assert.strictEqual(root.innerHTML, '<div><div>b</div></div>');
renderA = true;
invalidateApp[0]();
resolvers.resolve();
assert.strictEqual(root.innerHTML, '<div><div>a</div><div>b</div></div>');
});

it('Should insert result from widget in correct position', () => {
class Menu extends WidgetBase {
render() {
Expand Down