Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set total when side-loading data into a resource #701

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Mar 26, 2020

Type: bug
The following has been addressed in the PR:

Description:

This PR fixes an issue where the data total was not being set when set was used to side-load the resource data.

Resolves #700

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #701 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   97.76%   97.79%   +0.02%     
==========================================
  Files         119      119              
  Lines        6924     6925       +1     
  Branches     1572     1572              
==========================================
+ Hits         6769     6772       +3     
+ Misses        155      153       -2     
Impacted Files Coverage Δ
src/core/resource.ts 95.91% <100.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3442c85...cb2ec8d. Read the comment docs.

@tomdye tomdye merged commit f3d46e2 into dojo:master Mar 27, 2020
agubler pushed a commit to agubler/framework that referenced this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource doesn't set total when data passed
2 participants