Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resources Invalidation Strategy #882

Merged
merged 4 commits into from
Feb 28, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 21, 2021

Type: bug

The following has been addressed in the PR:

Description:

These changes address a few small bugs in the invalidation and caching logic used by resource:

  • Use same cache invalidation logic for updating an existing item as used when a "new" item is created
  • Fix calling read multiple times after the cache been invalidated
  • Decouple the request and the order part of the synthetic id, so we can track the data items associated at a request level

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a79bb38:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #882 (a79bb38) into master (69a6a61) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   94.45%   94.52%   +0.06%     
==========================================
  Files         127      127              
  Lines        8010     8020      +10     
  Branches     1872     1874       +2     
==========================================
+ Hits         7566     7581      +15     
+ Misses        444      439       -5     
Impacted Files Coverage Δ
src/core/middleware/resources.ts 95.68% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a6a61...a79bb38. Read the comment docs.

@agubler agubler merged commit 11a9e75 into dojo:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants