Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR builds should not be published to BDN nightly feed #1937

Closed
mawosoft opened this issue Mar 10, 2022 · 0 comments · Fixed by #2047
Closed

PR builds should not be published to BDN nightly feed #1937

mawosoft opened this issue Mar 10, 2022 · 0 comments · Fixed by #2047
Assignees
@mawosoft
Milestone
v0.13.2

Comments

@mawosoft
Copy link
Contributor

I'm opening this again (previously #1922) because it still seems to happen, plus there are some other shenanigans going on.

  • PR Fix optimization of action methods for coreclr #1935 published version 0.13.1.1707 on the AppVeyor feed.
  • But what's worse, subsequent new commits to an older PR Add CI for ARM32 #1077 were created with the same version 0.13.1.1707 and overwrote the already published version on the AppVeyor feed. Thus, the version number of the nightly builds becomes even more unreliable. Of course, NuGet still recognizes the changed SHA, but still...
@mawosoft mawosoft mentioned this issue Mar 10, 2022
Closed
@mawosoft mawosoft mentioned this issue May 19, 2022
Closed
mawosoft added a commit to mawosoft/BenchmarkDotNet that referenced this issue Jul 21, 2022
@mawosoft
Restrict what's published to AppVeyor NuGet feed (BDN nightly)
c8ee651 
- Fixes cake build regression introduced by switching from the old cake script
https://github.com/dotnet/BenchmarkDotNet/blob/a936815f2a58d9b728cfc5fe620bba17481c180c/build.cake#L151-L153
- and additionally excludes any builds triggered from commits to non-master branches.

The Cake Pack task is executed only if the build:
- runs on AppVeyor
- is not a PR
- is triggered from 'master' branch
- runs on Windows

Reason:
On AppVeyor, the packages produced by Pack are automatically uploaded as artifacts AND to the AppVeyor NuGet feed.
On GitHub and Azure Pipelines, Pack output is discarded anyway.

Fixes dotnet#1937.
@mawosoft mawosoft mentioned this issue Jul 21, 2022
Merged
adamsitnik pushed a commit that referenced this issue Jul 22, 2022
@mawosoft
Restrict what's published to AppVeyor NuGet feed (BDN nightly) (#2047)
d6020e9 
- Fixes cake build regression introduced by switching from the old cake script
https://github.com/dotnet/BenchmarkDotNet/blob/a936815f2a58d9b728cfc5fe620bba17481c180c/build.cake#L151-L153
- and additionally excludes any builds triggered from commits to non-master branches.

The Cake Pack task is executed only if the build:
- runs on AppVeyor
- is not a PR
- is triggered from 'master' branch
- runs on Windows

Reason:
On AppVeyor, the packages produced by Pack are automatically uploaded as artifacts AND to the AppVeyor NuGet feed.
On GitHub and Azure Pipelines, Pack output is discarded anyway.

Fixes #1937.
@adamsitnik adamsitnik added this to the v0.13.2 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mawosoft mawosoft

Labels
None yet
Projects
None yet
Milestone
v0.13.2
Development

Successfully merging a pull request may close this issue.

Restrict what's published to AppVeyor NuGet feed (BDN nightly) mawosoft/BenchmarkDotNet
2 participants
@adamsitnik @mawosoft