Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove L2 .NET Navigation Header #2344

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Remove L2 .NET Navigation Header #2344

merged 1 commit into from
Apr 30, 2020

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 29, 2020 •
edited
Loading

Internal Review - Note that the .NET Nav header has been removed

Fixes #2343

What was updated:
Removed the .NET header value of "MSDocsHeader-DotNet" from "uhfHeaderId" in docfx.json.

@wadepickett wadepickett self-assigned this Apr 29, 2020
@wadepickett wadepickett marked this pull request as ready for review April 30, 2020 00:08
JeremyLikness
JeremyLikness approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@JeremyLikness JeremyLikness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wadepickett wadepickett merged commit ab7d6d0 into master Apr 30, 2020
@smitpatel smitpatel deleted the wade-pickett/l2-remove-4-29 branch June 4, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@JeremyLikness JeremyLikness JeremyLikness approved these changes

Assignees

@wadepickett wadepickett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Layer - 2 (L2) .NET navigation header
3 participants
@wadepickett @smitpatel @JeremyLikness