Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win-arm64 to default RIDs #156

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Add win-arm64 to default RIDs #156

merged 1 commit into from
Feb 15, 2023

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented Jan 5, 2023

Summary

As pointed out by @zivkan in AB#1698505, the default RID list is missing win-arm64, which manifests as a failure to restore packages when targeting Windows ARM64 in legacy (non-SDK style) projects.

Fix

win-arm64 is a first-class supported platform so it is added to the default RID list, as suggested

Testing

Verified that the scenario of restoring an ARM64 .NET Framework app in Visual Studio works with this change.

@ladipro ladipro requested a review from tmeschter January 5, 2023 09:07
@ladipro
Copy link
Member Author

ladipro commented Jan 5, 2023

Asking @tmeschter for review per repo ownership.

@tmeschter
Copy link
Contributor

Manually kicked off a build and it passed. Merging.

@fowl2
Copy link

fowl2 commented Jun 28, 2023

Hi team, this breaks the build for non-sdk style projects using lock files see NuGet/Home#12711 for more details.

Is it possible this could be conditioned only on new TFMs?

@ladipro
Copy link
Member Author

ladipro commented Jun 28, 2023

Thank you for reporting this!

Is it possible this could be conditioned only on new TFMs?

Definitely possible but I'm not sure if it's correct to require developers to target 4.8.1 to build for arm64. For what it's worth, VS allows adding ARM64 as the project platform regardless of which Framework version is targeted. @tmeschter what do you think?

@fowl2
Copy link

fowl2 commented Jun 28, 2023

Is there a scenario where targeting pre 4.8.1 but including arm64 components makes sense? Given the only way to actually run an exe like this is using the IFEO registry key or start /machine? Maybe a library?

@ladipro
Copy link
Member Author

ladipro commented Jun 28, 2023

My experience with arm64 is limited but I would expect it to be fairly common to add the ARM64 platform to an existing project which targets an older version of the 4.* Framework, simply to make it run natively on arm64 HW. I don't think the version of the runtime actually used being 4.8.1 is super relevant. Framework has strong back-compat guarantees so targeting, say 4.5, and running on 4.8.1 should be fine.

adamint pushed a commit that referenced this pull request Sep 24, 2024
adamint pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants