Be explicit about FileShare mode when using FileStream. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know that by default `FileShare` will be `Read` when using a `FileStream`. However lets be totally clear on what we want from this point on, so if there is a problem we know its not us.
jonathanpeppers
approved these changes
Aug 6, 2024
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Aug 9, 2024
Changes: dotnet/android-tools@3debf8e...7ec795c * dotnet/android-tools@7ec795c: Be explicit about FileShare mode when using FileStream. (dotnet/android-tools#240) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Aug 14, 2024
Changes: dotnet/android-tools@3debf8e...7ec795c * dotnet/android-tools@7ec795c: Be explicit about FileShare mode when using FileStream. (dotnet/android-tools#240) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2055618
We know that by default
FileSharewill beReadwhen using aFileStream. However lets be totally clear on what we want from this point on, so if there is a problem we know its not us.