-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Configuration for Xamarin.Android.sln #23
Conversation
How was the configuration "broken"? What IDE reported warnings, and what were those warnings? |
If you loaded the .sln in Xamarin studio it defaults to the `Debug` configuration. As a result the Java.Interop project is NOT built as part of that configuration. This is because it was looking for a Mapping that did not exist in that project. While it didn't stop the build, it did looks odd and might cause confusion for users. Other configurations have also been updated to make sure all the projects are building the correct projects
@jonpryor updated with comments :) |
Java.Interop isn't supposed to be built in the Debug configuration. It shouldn't be built in any Xamarin.Android configuration...except by Mono.Android.targets as a (The reason/rationale for this is that the original Java.Interop Debug configuration was "green field let's reimplement everything!", and when Cycle 7 had the opportunity for integration I didn't want to bring in everything -- it would be too destabilizing -- so Java.Interop got the |
@@ -112,6 +112,7 @@ Global | |||
{94BD81F7-B06F-4295-9636-F8A3B6BDC762}.XAIntegrationDebug|Any CPU.Build.0 = XAIntegrationDebug|Any CPU | |||
{94BD81F7-B06F-4295-9636-F8A3B6BDC762}.XAIntegrationRelease|Any CPU.ActiveCfg = XAIntegrationRelease|Any CPU | |||
{94BD81F7-B06F-4295-9636-F8A3B6BDC762}.XAIntegrationRelease|Any CPU.Build.0 = XAIntegrationRelease|Any CPU | |||
{94BD81F7-B06F-4295-9636-F8A3B6BDC762}.Debug|AnyCPU.Build.0 = Debug|Any CPU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per previous comment, this line shouldn't be added.
If you loaded the .sln in Xamarin studio it defaults to the
Debug
configuration. As a result the Java.Interop project isNOT built as part of that configuration. This is because it was
looking for a Mapping that did not exist in that project.
While it didn't stop the build, it did looks odd and might cause
confusion for users.
Other configurations have also been updated to make sure all the
projects are building the correct projects