Enable lazy loading of AOTd assemblies #6940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
requested review from
jonpryor,
dellis1972 and
jonathanpeppers
as code owners
Yep, I will time it in a few, want to fix the test failures first |
|
Unfortunately, enabling the feature for 64-bit targets results in this Mono runtime abort: |
|
@lambdageek @vargaz ideas about the issue above? Should we just file an issue on dotnet/runtime? |
|
@jonathanpeppers I already talked to @vargaz, we'll continue tomorrow :) |
|
Please don't merge until #6946 is in and I can rebase this PR on it |
grendello
force-pushed
the
aot-lazy-load
branch
2 times, most recently
from
9c2d44d to
37125ef
Compare
jonathanpeppers
approved these changes
Apr 22, 2022
Fixes: dotnet#6935 Context: dotnet/runtime#67024 Add support for enabling lazy loading of AOTd assemblies and their associated shared libraries, when targetting .NET6+. The feature is enabled by default when AOT is enabled for `Release` builds and can be disabled by setting the new `$(AndroidAotEnableLazyLoad)` MSBuild property to `false`.
grendello
force-pushed
the
aot-lazy-load
branch
from
37125ef to
0c32643
Compare
Fixes: https://github.com/xamarin/xamarin-android/issues/6935
Context: https://github.com/dotnet/runtime/pull/67024
Add support for enabling lazy loading of AOTd assemblies and their
associated shared libraries, when targeting .NET6+.
The feature is enabled by default when AOT is enabled for `Release`
builds and can be disabled by setting the new
`$(AndroidAotEnableLazyLoad)` MSBuild property to `false`.
Performance gains are obvious, but their scale depends on where we look.
Results of running a Hello World MAUI app on Pixel 6 Pro, with:
See PR for full timing details.
With:
* `$(RuntimeIdentifier)`=android-arm64
* `$(AndroidEnablePreloadAssemblies)`=False
* `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True
| Scenario | Before | After | Δ |
| ------------------------------------- | --------: | --------: | --------: |
| `ActivityTaskManager: Displayed` time | 367.800 | 368.200 | +0.11% ✗ |
| `JNIEnv.Initialize()` time | 6.221 | 5.367 | -13.73% ✓ |
| Total native init time | 39.047 | 20.395 | -47.77% ✓ |
With:
* `$(RuntimeIdentifier)`=android-arm
* `$(AndroidEnablePreloadAssemblies)`=True
* `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True
| Scenario | Before | After | Δ |
| ------------------------------------- | --------: | --------: | --------: |
| `ActivityTaskManager: Displayed` time | 490.600 | 475.000 | -3.18% ✓ |
| `JNIEnv.Initialize()` time | 8.602 | 7.787 | -9.48% ✓ |
| Total native init time | 47.726 | 27.156 | -43.10% ✓ | |
jonathanpeppers
pushed a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Apr 25, 2022
Backports: dotnet#6940 Fixes: dotnet#6935 Context: dotnet/runtime#67024 Add support for enabling lazy loading of AOTd assemblies and their associated shared libraries, when targeting .NET6+. The feature is enabled by default when AOT is enabled for `Release` builds and can be disabled by setting the new `$(AndroidAotEnableLazyLoad)` MSBuild property to `false`. Performance gains are obvious, but their scale depends on where we look. Results of running a Hello World MAUI app on Pixel 6 Pro, with: See PR for full timing details. With: * `$(RuntimeIdentifier)`=android-arm64 * `$(AndroidEnablePreloadAssemblies)`=False * `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True | Scenario | Before | After | Δ | | ------------------------------------- | --------: | --------: | --------: | | `ActivityTaskManager: Displayed` time | 367.800 | 368.200 | +0.11% ✗ | | `JNIEnv.Initialize()` time | 6.221 | 5.367 | -13.73% ✓ | | Total native init time | 39.047 | 20.395 | -47.77% ✓ | With: * `$(RuntimeIdentifier)`=android-arm * `$(AndroidEnablePreloadAssemblies)`=True * `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True | Scenario | Before | After | Δ | | ------------------------------------- | --------: | --------: | --------: | | `ActivityTaskManager: Displayed` time | 490.600 | 475.000 | -3.18% ✓ | | `JNIEnv.Initialize()` time | 8.602 | 7.787 | -9.48% ✓ | | Total native init time | 47.726 | 27.156 | -43.10% ✓ |
jonathanpeppers
added a commit
that referenced
this pull request
Apr 26, 2022
Backports: #6940 Fixes: #6935 Context: dotnet/runtime#67024 Add support for enabling lazy loading of AOTd assemblies and their associated shared libraries, when targeting .NET6+. The feature is enabled by default when AOT is enabled for `Release` builds and can be disabled by setting the new `$(AndroidAotEnableLazyLoad)` MSBuild property to `false`. Performance gains are obvious, but their scale depends on where we look. Results of running a Hello World MAUI app on Pixel 6 Pro, with: See PR for full timing details. With: * `$(RuntimeIdentifier)`=android-arm64 * `$(AndroidEnablePreloadAssemblies)`=False * `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True | Scenario | Before | After | Δ | | ------------------------------------- | --------: | --------: | --------: | | `ActivityTaskManager: Displayed` time | 367.800 | 368.200 | +0.11% ✗ | | `JNIEnv.Initialize()` time | 6.221 | 5.367 | -13.73% ✓ | | Total native init time | 39.047 | 20.395 | -47.77% ✓ | With: * `$(RuntimeIdentifier)`=android-arm * `$(AndroidEnablePreloadAssemblies)`=True * `$(AndroidUseAssemblyStore)`=True, `$(AndroidEnableAssemblyCompression)`=True | Scenario | Before | After | Δ | | ------------------------------------- | --------: | --------: | --------: | | `ActivityTaskManager: Displayed` time | 490.600 | 475.000 | -3.18% ✓ | | `JNIEnv.Initialize()` time | 8.602 | 7.787 | -9.48% ✓ | | Total native init time | 47.726 | 27.156 | -43.10% ✓ | Co-authored-by: Marek Habersack <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6935
Context: dotnet/runtime#67024
Add support for enabling lazy loading of AOTd assemblies and their
associated shared libraries, when targetting .NET6+.
The feature is enabled by default when AOT is enabled for
Releasebuilds and can be disabled by setting the new
$(AndroidAotEnableLazyLoad)MSBuild property tofalse.Performance gains are obvious, but their scale depends on where we look.
Results of running a Hello World MAUI app on Pixel 6 Pro:
Displayed time:
Just the
JNIEnv.Initializecall during native init:Total time taken by the native init (before handing control over to the managed
land):