Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix TestResolveToolsExists on .NET #8445

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[Tests] Fix TestResolveToolsExists on .NET #8445

merged 1 commit into from
Oct 23, 2023

Conversation

pjcollins
Copy link
Member

The TestResolveToolsExists test currently requires a Xamarin.Android
installation on disk to pass. The test has been fixed by passing the
.NET reference assembly paths to the ResolveXamarinAndroidTools task.

The build has also been updated to allow this test to pass against a
local build tree, as it requires product Version files in the SDK
output directory.

@pjcollins
[Tests] Fix TestResolveToolsExists on .NET
3228f84 
The `TestResolveToolsExists` test currently requires a Xamarin.Android
installation on disk to pass.  The test has been fixed by passing the
.NET reference assembly paths to the `ResolveXamarinAndroidTools` task.

The build has also been updated to allow this test to pass against a
local build tree, as it requires product `Version` files in the SDK
output directory.
@pjcollins pjcollins marked this pull request as ready for review October 20, 2023 21:03
@pjcollins pjcollins merged commit afd1274 into dotnet:main Oct 23, 2023
@pjcollins pjcollins deleted the no-classic-env branch October 23, 2023 15:52
grendello added a commit that referenced this pull request Oct 24, 2023
@grendello
Merge branch 'main' into dev/grendel/assembly-blobs-per-rid
9c5838f 
* main:
  [ci] Stop building monodroid in builds from forks (#8444)
  [docs] Don't overwrite xml produced by docs build (#8451)
  Bump NDK to r26b (#8450)
  [Tests] Fix TestResolveToolsExists on .NET (#8445)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@dellis1972 dellis1972 Awaiting requested review from dellis1972 dellis1972 is a code owner

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjcollins @jonathanpeppers