Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono.Android] is now "trimming safe" #8778

Merged
merged 6 commits into from
Mar 13, 2024
Merged

[Mono.Android] is now "trimming safe" #8778

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6399051
[Mono.Android] is now "trimming safe"
jonathanpeppers Feb 29, 2024
e4bbe8c
Changes to make diff in `AndroidEnvironment` smaller
jonathanpeppers Mar 11, 2024
3e34f0f
Set `$(IlcTreatWarningsAsErrors)`
jonathanpeppers Mar 11, 2024
ffd33ed
One less IL2068 suppression
jonathanpeppers Mar 11, 2024
db695b4
[DAM] not needed on JavaCollection<T>, JavaList<T>, JavaDictionary<K,V>
jonathanpeppers Mar 11, 2024
79b9908
Update justification message
jonathanpeppers Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Mono.Android/Java.Interop/JavaConvert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,13 @@ static class JavaConvert {

static Func<IntPtr, JniHandleOwnership, object?>? GetJniHandleConverter (Type? target)
{
const string justification = "JavaDictionary<,>, JavaList<>, and JavaCollection<> use DynamicallyAccessedMembers for PublicMethods to preserve FromJniHandle().";
[UnconditionalSuppressMessage ("Trimming", "IL2055", Justification = justification)]
[UnconditionalSuppressMessage ("Trimming", "IL2068", Justification = justification)]
[UnconditionalSuppressMessage ("Trimming", "IL2055", Justification = "JavaDictionary<,>, JavaList<>, and JavaCollection<> are preserved by the MarkJavaObjects linker step.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

Nit: The justification doesn't apply to the warning - see my other comment about the reason for the warning.

[return: DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
static Type MakeGenericType (Type type, params Type [] typeArguments) =>
static Type MakeGenericType (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
Type type,
params Type [] typeArguments
) =>
// FIXME: https://github.com/xamarin/xamarin-android/issues/8724
// IL3050 disabled in source: if someone uses NativeAOT, they will get the warning.
#pragma warning disable IL3050
Expand Down
Loading