Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 7 feed updates #10205

Merged
merged 1 commit into from
Jul 29, 2022
Merged

.NET 7 feed updates #10205

merged 1 commit into from
Jul 29, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jul 29, 2022

Addresses #10203

  • Make RC 1 and RC 2 internal channels
  • Add internal variants for the 7.0 and 7.0.1xx GA channels
  • Update the setup nuget sources scripts to support net7 and simplify them a bit

To double check:

Addresses dotnet#10203
- Make RC 1 and RC 2 internal channels
- Add internal variants for the 7.0 and 7.0.1xx GA channels
- Update the setup nuget sources scripts to support net7
@mmitche mmitche requested a review from riarenas July 29, 2022 18:18
@riarenas
Copy link
Member

I like the changes to the scripts

@mmitche
Copy link
Member Author

mmitche commented Jul 29, 2022

I like the changes to the scripts

Yep, they are better. I am wondering whether it's time to move away from the feed credential, and instead use the built-in tasks. I wonder if we are paying a performance penalty for the v2 feed format. We originally used it simply because of the flakiness of the feed auth plugin but that probably no longer applies.

@riarenas
Copy link
Member

Hmm yeah it's possible we can now just have the scripts add the feeds to the nuget config and make sure the auth task / x-org scripts are added to the templates / custom repo yaml when running in internal.

@mmitche mmitche merged commit 5581c96 into dotnet:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants