Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable signing validation of rpm files using SignCheck #15560

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 20, 2025

Closes dotnet/source-build#4860

  • src/SignCheck/Microsoft.SignCheck/Verification/LinuxPackageVerifier.cs: Added a new abstract class to handle common logic for verifying Linux packages.
  • src/SignCheck/Microsoft.SignCheck/Verification/DebVerifier.cs: Refactored to inherit from the new LinuxPackageVerifier class and moved common logic to the base class.
  • src/SignCheck/Microsoft.SignCheck/Verification/RpmVerifier.cs: Added a new class to handle verification and unpacking of .rpm packages.
  • src/SignCheck/Microsoft.SignCheck/Verification/SignatureVerificationManager.cs: Registered the new RpmVerifier class.

@ellahathaway ellahathaway changed the title Signcheck rpm Enable signing validation of rpm files using SignCheck Feb 20, 2025
@ellahathaway ellahathaway requested a review from mmitche February 21, 2025 16:05
@ellahathaway ellahathaway marked this pull request as ready for review February 21, 2025 16:05
mmitche
mmitche previously approved these changes Feb 21, 2025
@ellahathaway
Copy link
Member Author

Validated these changes in this pipeline run

@ellahathaway ellahathaway merged commit 5ac62fa into dotnet:main Feb 24, 2025
11 checks passed
@ellahathaway ellahathaway deleted the signcheck-rpm branch February 24, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable signing validation of .rpm files using SignCheck
2 participants