AspireShop: Simplify WithHttpCommand #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR simplifies the AspireShop sample by consolidating HTTP command creation. The key changes are:
- Removal of the separate WithHttpsCommand method in favor of WithHttpCommand.
- Modification of the WithHttpCommand overload to accept an array of endpoint names.
- Removal of the scheme validation check in WithHttpCommandImpl.
Reviewed Changes
| File | Description |
|---|---|
| samples/AspireShop/AspireShop.AppHost/ResourceBuilderExtensions.cs | Consolidates HTTP command methods, updates endpoint name handling, and removes the expected scheme check. |
| samples/AspireShop/AspireShop.AppHost/Program.cs | Updates usage of the HTTP command helper from WithHttpsCommand to WithHttpCommand. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
eerhardt
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the AspireShop sample so that the
WithHttpCommandworks by default against endpoints named "https" or "http".Fixes #677