Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workload-testing] Update testing nuget, and remove some workarounds #2746

Closed
wants to merge 2 commits into from
Closed

[workload-testing] Update testing nuget, and remove some workarounds #2746

wants to merge 2 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Mar 9, 2024 •
edited
Loading

Contributes to e2e follow up work - #2687 .

Update Microsoft.NET.Runtime.WorkloadTesting.Internal to 9.0.0-preview.3.24158.8

[workload-testing] Remove the hacks, and use the update task

  1. remove package source mapping from `nuget.config` as it gets added at
     build time now
  2. Manifest packages are installed with a `PackageDownload` instead of a
     `PackageReference`, thus it can work with
     `PackageType='dotnetplatform'` packages.
  3. Generating a patched nuget.config for building test projects can be
     done using a new `PatchNuGetConfig` task, and thus we can remove the
     inline task.
Microsoft Reviewers: Open in CodeFlow

radical added 2 commits March 8, 2024 20:13
@radical
Update Microsoft.NET.Runtime.WorkloadTesting.Internal to 9.0.0-previe…
98b893b 
…w.3.24158.8
@radical
[workload-testing] Remove the hacks, and use the update task
5bc4fd5 
1. remove package source mapping from `nuget.config` as it gets added at
   build time now
2. Manifest packages are installed with a `PackageDownload` instead of a
   `PackageReference`, thus it can work with
   `PackageType='dotnetplatform'` packages.
3. Generating a patched nuget.config for building test projects can be
   done using a new `PatchNuGetConfig` task, and thus we can remove the
   inline task.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Mar 9, 2024
@radical radical mentioned this pull request Mar 9, 2024
Closed
9 tasks
@radical radical requested review from eerhardt and joperezr March 9, 2024 01:33
@radical radical closed this Mar 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

@joperezr joperezr Awaiting requested review from joperezr

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radical