Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polly dependency to latest release? #31705

Closed
martincostello opened this issue Apr 12, 2021 · 5 comments
Closed

Update Polly dependency to latest release? #31705

martincostello opened this issue Apr 12, 2021 · 5 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@martincostello
Copy link
Member

Is your feature request related to a problem? Please describe.

ASP.NET Core currently depends on Polly 7.1.0, which was released in March 2019.

<PollyVersion>7.1.0</PollyVersion>

Since then there have been a number of minor releases, the most recent being yesterday to 7.2.2, to fix a number of bugs and minor improvements (CHANGELOG).

Describe the solution you'd like

Update the Polly dependency to the latest release, 7.2.2.

Updating to at least 7.2.0 would also make the new IConcurrentPolicyRegistry interface available, which could then be registered by default in the Polly extensions for HttpClientFactory: #28283 (comment).

Assuming there isn't a specific reason to pin the dependency at 7.1.0, I'd be happy to raise a PR to update the minimum version for ASP.NET Core 6.0.

@javiercn javiercn added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 12, 2021
@javiercn
Copy link
Member

@martincostello thanks for contacting us.

Are there known breaking changes between 7.2.2 and 7.1.0? I think we would be open to a PR if there are no breaking changes, otherwise we would need to evaluate the impact.

@javiercn javiercn added good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue labels Apr 12, 2021
@javiercn javiercn added this to the Next sprint planning milestone Apr 12, 2021
@ghost
Copy link

ghost commented Apr 12, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@martincostello
Copy link
Member Author

@javiercn No, there shouldn't be any breaking changes. There's no changes to the public API other than the addition of the new IConcurrentPolicyRegistry interface and PolicyRegistry implementing it. All the other changes are just bug fixes.

If you'd be happy to accept a PR to update the dependency then I'll open one later on today 👍

@javiercn
Copy link
Member

@martincostello go for it.

martincostello added a commit to martincostello/aspnetcore that referenced this issue Apr 12, 2021
Update Polly dependency to the latest version of the package.
Addresses dotnet#31705.
@BrennanConroy
Copy link
Member

Done via #31708

@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

No branches or pull requests

3 participants