-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand and update for 5.0.1 #27406
Rebrand and update for 5.0.1 #27406
Conversation
We'll need this general improvement in the veracity of template tests when rebranding for 5.0.1. If others prefer, could take more of this from master e.g. turn off |
This is blocked for now. Right @wtgodbe❔ |
That's correct, 5.0.1 servicing will open up later this month |
- required for some tests to pass
… master - [master] Update dependencies from dotnet/runtime dotnet/efcore (#26788) - 219ecd6 - when project template tests run test assets, need latest shared Fx bits - hit `BadImageFormatException`s otherwise - test projects build against uploaded packages - those packages reference the 5.0.1 shared framework - the ASP.NET parts of the 5.0.1 shared Fx are `crossgen`ed to target Windows - Use runtime and ref/ assemblies matching repo in Helix testing - add Directory.Build.*.in files based on project template test infrastructure - use files as import boundary where the project doesn't create its own Directory.Build.* files - ensure `dotnet-watch` tests also use the latest runtime and ref/ assemblies - Extend Helix Directory.Build.* workarounds - generate Directory.Build.* files when restoring any projects - include generated files in Helix runs needing the latest runtime - copy generated files when testing `dotnet-watch` locally - include generated content in Microsoft.NET.Sdk.BlazorWebAssembly.IntegrationTests test assets - remove duplicate settings from existing Directory.Build.* files - ensure shared framework and targeting packs are laid out under .dotnet/ before test assets restore - Disable `crossgen` when building for Helix runs - make `$(CrossgenOutput)` property override-able - use override in CI jobs that submit to other platforms - for now, leave the ARM64 Helix jobs alone (build on Ubuntu, run in Debian)
- affected projects are all test assets or provide test support - without this, a number of the projects are incorrectly marked as shipping
- this is a complete rewrite of eng/Baseline.xml - based on the 5.0.0 MergedManifest.xml file
9c94fd8
to
ce07c34
Compare
$(CrossgenOutput)
and Directory.Build.*.in changes from master
This branch now includes everything that should be needed to get 5.0.1 builds going. I suspect it won't validate until the 5.0.100 SDK is usable in |
- need consistent versions when servicing targeting packs
* Move to 5.0.1 versions * Move to GA .NET SDK - required for some tests to pass * Remove feeds that won't be needed after 5.0.0 is GA * Cherry-pick `$(CrossgenOutput)` and Directory.Build.*.in changes from master - [master] Update dependencies from dotnet/runtime dotnet/efcore (dotnet/aspnetcore#26788) - 219ecd688012 - when project template tests run test assets, need latest shared Fx bits - hit `BadImageFormatException`s otherwise - test projects build against uploaded packages - those packages reference the 5.0.1 shared framework - the ASP.NET parts of the 5.0.1 shared Fx are `crossgen`ed to target Windows - Use runtime and ref/ assemblies matching repo in Helix testing - add Directory.Build.*.in files based on project template test infrastructure - use files as import boundary where the project doesn't create its own Directory.Build.* files - ensure `dotnet-watch` tests also use the latest runtime and ref/ assemblies - Extend Helix Directory.Build.* workarounds - generate Directory.Build.* files when restoring any projects - include generated files in Helix runs needing the latest runtime - copy generated files when testing `dotnet-watch` locally - include generated content in Microsoft.NET.Sdk.BlazorWebAssembly.IntegrationTests test assets - remove duplicate settings from existing Directory.Build.* files - ensure shared framework and targeting packs are laid out under .dotnet/ before test assets restore - Disable `crossgen` when building for Helix runs - make `$(CrossgenOutput)` property override-able - use override in CI jobs that submit to other platforms - for now, leave the ARM64 Helix jobs alone (build on Ubuntu, run in Debian) * Correct an `$(IsTestAssetProject)` setting - affected projects are all test assets or provide test support - without this, a number of the projects are incorrectly marked as shipping * Baseline released 5.0.0 packages - this is a complete rewrite of eng/Baseline.xml - based on the 5.0.0 MergedManifest.xml file * Add 5.0.0 PackageOverrides.txt and PlatformManifest.txt files - need consistent versions when servicing targeting packs Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Commit migrated from dotnet/aspnetcore@352ad1a9804a
[master] Update dependencies from dotnet/runtime dotnet/efcore ([master] Update dependencies from dotnet/runtime dotnet/efcore #26788)
when project template tests run test assets, need latest shared Fx bits
hit
BadImageFormatException
s otherwisecrossgen
ed to target WindowsUse runtime and ref/ assemblies matching repo in Helix testing
dotnet-watch
tests also use the latest runtime and ref/ assembliesExtend Helix Directory.Build.* workarounds
dotnet-watch
locallyDisable
crossgen
when building for Helix runs$(CrossgenOutput)
property override-able