Code

Error boundaries#30874

Code

Merged

SteveSandersonMS merged 55 commits intomaindotnet/aspnetcore:mainfrom stevesa/error-boundariesdotnet/aspnetcore:stevesa/error-boundariesCopy head branch name to clipboardApr 8, 2021

+1,310-38

Commits

Commits on Apr 6, 2021

• Initial experiments

  SteveSandersonMS

  committed
  c0d3d59

  Copy full SHA for c0d3d59

• Handle async event handler exceptions

  SteveSandersonMS

  committed
  952cac0

  Copy full SHA for 952cac0

• Test cases for lifecycle methods

  SteveSandersonMS

  committed
  4b12fc2

  Copy full SHA for 4b12fc2

• Handle SetParametersAsync exceptions

  SteveSandersonMS

  committed
  cc44e53

  Copy full SHA for cc44e53

• Handle IHandleAfterRender exceptions

  SteveSandersonMS

  committed
  5351089

  Copy full SHA for 5351089

• Handle exceptions during rendering

  SteveSandersonMS

  committed
  4e7e3c5

  Copy full SHA for 4e7e3c5

• Update notes about disposal

  SteveSandersonMS

  committed
  e6c1c1c

  Copy full SHA for e6c1c1c

• Add note about Attach

  SteveSandersonMS

  committed
  0d6acd7

  Copy full SHA for 0d6acd7

• Handle exceptions during cascading value notifications

  SteveSandersonMS

  committed
  2b35fe8

  Copy full SHA for 2b35fe8

• Update ErrorMaker.razor

  SteveSandersonMS

  committed
  42d1911

  Copy full SHA for 42d1911

• Add note about InvokeAsync

  SteveSandersonMS

  committed
  2f68770

  Copy full SHA for 2f68770

• Clean up some notes

  SteveSandersonMS

  committed
  80ebf30

  Copy full SHA for 80ebf30

• Clarify what we do if the IErrorBoundary component itself has an error

  SteveSandersonMS

  committed
  83de667

  Copy full SHA for 83de667

• Force error boundaries to clear up their descendants on error, even before we notify them. Also think about infinite error loops.

  SteveSandersonMS

  committed
  2a5a7d3

  Copy full SHA for 2a5a7d3

• More thoughts on error loops

  SteveSandersonMS

  committed
  0cd43ff

  Copy full SHA for 0cd43ff

• More thoughts

  SteveSandersonMS

  committed
  0a7a07f

  Copy full SHA for 0a7a07f

• Clean up all the stuff about detailed errors and prerendering

  SteveSandersonMS

  committed
  8089c36

  Copy full SHA for 8089c36

• Add PrerenderingErrorBoundaryLogger

  SteveSandersonMS

  committed
  4514899

  Copy full SHA for 4514899

• Let error boundaries catch their own inline errors

  SteveSandersonMS

  committed
  2de4259

  Copy full SHA for 2de4259

• Redesign around ErrorBoundaryBase abstract base class.

  SteveSandersonMS

  committed
  415d8dd

  Copy full SHA for 415d8dd

• Define IErrorBoundary as an internal interface for clarity

  SteveSandersonMS

  committed
  9529163

  Copy full SHA for 9529163

• Minor fix

  SteveSandersonMS

  committed
  bf04cf3

  Copy full SHA for bf04cf3

• Handle logging errors

  SteveSandersonMS

  committed
  1db319e

  Copy full SHA for 1db319e

• Make it possible to customize the UI via subclassing ErrorBoundary

  SteveSandersonMS

  committed
  0415115

  Copy full SHA for 0415115

• Better default UI

  SteveSandersonMS

  committed
  a28c3ca

  Copy full SHA for a28c3ca

• Show you can subclass ErrorBoundary helpfully

  SteveSandersonMS

  committed
  275ae5a

  Copy full SHA for 275ae5a

• Rename AutoReset->AutoRecover

  SteveSandersonMS

  committed
  d319b9f

  Copy full SHA for d319b9f

• Remove use of linq

  SteveSandersonMS

  committed
  15ab863

  Copy full SHA for 15ab863

• Tidy up comments

  SteveSandersonMS

  committed
  990128e

  Copy full SHA for 990128e

• Clean up and expand test cases

  SteveSandersonMS

  committed
  c9c7c6f

  Copy full SHA for c9c7c6f

• CR: Add general-purpose OnErrorAsync to base class

  SteveSandersonMS

  committed
  2f597f4

  Copy full SHA for 2f597f4

• Remove AutoRecover feature because it can be done in user code now we have Recover

  SteveSandersonMS

  committed
  29e4760

  Copy full SHA for 29e4760

• Unit tests for component error boundary dispatch logic

  SteveSandersonMS

  committed
  08d4595

  Copy full SHA for 08d4595

• Make async flow clearer

  SteveSandersonMS

  committed
  7540d3a

  Copy full SHA for 7540d3a

• Fix unrelated test code badness

  SteveSandersonMS

  committed
  34e6519

  Copy full SHA for 34e6519

• Add E2E test UI

  SteveSandersonMS

  committed
  06da1ef

  Copy full SHA for 06da1ef

• Begin scripting E2E cases

  SteveSandersonMS

  committed
  259f5d5

  Copy full SHA for 259f5d5

Commits on Apr 7, 2021

• Add some E2E tests for more difficult cases

  SteveSandersonMS

  committed
  63d950b

  Copy full SHA for 63d950b

• Cope with receiving errors while already in an error state

  SteveSandersonMS

  committed
  ae4cdc4

  Copy full SHA for ae4cdc4

• Add failing unit test for errors after disposal

  SteveSandersonMS

  committed
  76f41fe

  Copy full SHA for 76f41fe

• Have renderer cope with errors after disposal

  SteveSandersonMS

  committed
  f5be9f1

  Copy full SHA for f5be9f1

• Better handling of error loops

  SteveSandersonMS

  committed
  31def59

  Copy full SHA for 31def59

• Fix description

  SteveSandersonMS

  committed
  015b4e2

  Copy full SHA for 015b4e2

• Tidyup

  SteveSandersonMS

  committed
  832f72a

  Copy full SHA for 832f72a

• Revert some unwanted changes

  SteveSandersonMS

  committed
  50c9ddb

  Copy full SHA for 50c9ddb

• More cleanup

  SteveSandersonMS

  committed
  7df7d5a

  Copy full SHA for 7df7d5a

• Add default error boundary content/style to project templates

  SteveSandersonMS

  committed
  0a61aaa

  Copy full SHA for 0a61aaa

• Fix server E2E tests

  SteveSandersonMS

  committed
  4955cc3

  Copy full SHA for 4955cc3

• Test for custom error boundary

  SteveSandersonMS

  committed
  92e506b

  Copy full SHA for 92e506b

• Test for error ignorer

  SteveSandersonMS

  committed
  8f18c40

  Copy full SHA for 8f18c40

• Test for inline errors

  SteveSandersonMS

  committed
  d151976

  Copy full SHA for d151976

• Test for errors after disposal

  SteveSandersonMS

  committed
  d85c8d2

  Copy full SHA for d85c8d2

• Test for multiple concurrent errors

  SteveSandersonMS

  committed
  00e5e50

  Copy full SHA for 00e5e50

• Stronger guidance to override OnErrorAsync

  SteveSandersonMS

  committed
  5eae0b1

  Copy full SHA for 5eae0b1

Commits on Apr 8, 2021

• CR: Improve unit test

  SteveSandersonMS

  committed
  9ace45d

  Copy full SHA for 9ace45d