Improve linker friendliness for RouteOptions #38014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added API to allows setting parameter policies in a linker friendly way - Added tests - Updated solution filter
davidfowl
requested review from
BrennanConroy,
halter73,
javiercn and
Tratcher
as code owners
ghost
added
the
|
Feel free to review the words. I didn't put too much effort into it. |
javiercn
reviewed
Nov 2, 2021
Kahbazi
reviewed
Nov 2, 2021
davidfowl
commented
Nov 2, 2021
Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Kahbazi <[email protected]>
halter73
approved these changes
Nov 2, 2021
Co-authored-by: Pranav K <[email protected]>
eerhardt
reviewed
Nov 2, 2021
| @@ -72,6 +72,7 @@ internal ICollection<EndpointDataSource> EndpointDataSources | |||
| /// </summary> | |||
| public IDictionary<string, Type> ConstraintMap | |||
| { | |||
| [RequiresUnreferencedCode($"The linker cannot determine what constraints are being added via the ConstraintMap property. Prefer {nameof(RouteOptions)}.{nameof(SetParameterPolicy)} instead for setting constraints. This warning can be suppressed if this property is being used to read of delete constraints.")] | |||
There was a problem hiding this comment.
Don't say linker in public facing docs/strings. Instead, we prefer the term trimmer or trimming.
is being used to read of delete constraints.
I'm not sure I understand what that means. Is there a type-o or missing word?
eerhardt
reviewed
Nov 2, 2021
| @@ -72,6 +72,7 @@ internal ICollection<EndpointDataSource> EndpointDataSources | |||
| /// </summary> | |||
| public IDictionary<string, Type> ConstraintMap | |||
| { | |||
| [RequiresUnreferencedCode($"The linker cannot determine what constraints are being added via the ConstraintMap property. Prefer {nameof(RouteOptions)}.{nameof(SetParameterPolicy)} instead for setting constraints. This warning can be suppressed if this property is being used to read of delete constraints.")] | |||
| get | |||
| { | |||
| return _constraintTypeMap; | |||
There was a problem hiding this comment.
Don't you also need a RequiresUnreferencedCode attribute on the setter?
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24723