Support OpenAPI summaries and descriptions on minimal endpoints #40088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
force-pushed
the
safia/openapi-example-desc
branch
2 times, most recently
from
e633ce5 to
bfff399
Compare
Kahbazi
reviewed
Feb 9, 2022
src/Http/Routing/src/Builder/OpenApiRouteHandlerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
captainsafia
commented
Feb 9, 2022
Pilchie
added
the
old-area-web-frameworks-do-not-use
pranavkm
reviewed
Feb 9, 2022
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/openapi-example-desc
branch
from
c193bd6 to
1fe0bd3
Compare
captainsafia
requested review from
javiercn,
Tratcher,
BrennanConroy and
halter73
as code owners
src/Http/Routing/src/Builder/OpenApiRouteHandlerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Http/Routing/src/Builder/OpenApiRouteHandlerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/openapi-example-desc
branch
from
d2803ef to
2b9e6e7
Compare
|
@BrennanConroy @pranavkm With the API approved, can I get a review on this PR? TY! |
BrennanConroy
approved these changes
Feb 15, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
captainsafia
force-pushed
the
safia/openapi-example-desc
branch
from
2b9e6e7 to
95ff9ed
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/aspnet-build Can I get help merging? |
|
Actually I shouldn't have merged w/o confirmation this was 🆗 to add to preview2. @Pilchie should we revert the change, let it stand, take it to Steve, …❔ |
|
No, leave it. |
captainsafia
added a commit
that referenced
this pull request
Mar 15, 2022
* Support OpenAPI summaries and descriptions on minimal endpoints * Prefix new types with 'Endpoint' * Bring back docstring fixes * Remove AttributeTargets.Delegate from attributes
captainsafia
added a commit
that referenced
this pull request
Mar 15, 2022
…) (#40718) * Support OpenAPI summaries and descriptions on minimal endpoints * Prefix new types with 'Endpoint' * Bring back docstring fixes * Remove AttributeTargets.Delegate from attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37906.