Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip][blazor] Delegate loading of assets to runtime #42770

Closed
wants to merge 1 commit into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 17, 2022

  • Uses config.assets to pass list of resources to load to runtime.
  • Uses new downloadResource callback to provide caching implementation of resource loader
  • Switched to postRunAsync, simplified preRun and removed need for onRuntimeInitialized
  • Moved methods getSatelliteAssemblies, getLazyAssemblies

Requires dotnet/runtime#72275 as pre-requisite.

@pavelsavara pavelsavara added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 17, 2022
@pavelsavara pavelsavara added this to the 7.0-rc1 milestone Jul 17, 2022
@pavelsavara pavelsavara self-assigned this Jul 17, 2022
@SteveSandersonMS
Copy link
Member

Thanks @pavelsavara.

In general, things that move runtime-like logic into the runtime are good to do, so we'd surely be pleased to take a change like this.

We just need to ensure that we retain the same functionality as before around things like:

  • Custom resource loaders
  • Lazy loading
  • Caching
  • Integrity checking
  • Progress reporting (this is new BTW)

Other than the progress reporting which I can see is missing, it's totally possible you've already kept all the functionality in place - it's a bit hard to tell though because there are so many code changes. When this PR is ready for review, would you please be able to write up a description of exactly what has changed in the flow and why?

It would also be valuable to understand how essential it is to include this in .NET 7. It's quite late to take a change that reshuffles so many things as we'll have limited opportunities to catch any edge-case regressions.

Thanks!

@pavelsavara pavelsavara modified the milestones: 7.0-rc1, .NET 8 Planning Jul 20, 2022
@pavelsavara
Copy link
Member Author

Moved to Net8

@pavelsavara
Copy link
Member Author

Replaced by #46532

@pavelsavara pavelsavara closed this Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Hi @pavelsavara. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants