Sync shared code from runtime #57440
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -151,25 +151,6 @@ public void DecodesIndexedHeaderField_DynamicTable() | |||
| Assert.Equal(_headerValueString, _handler.DecodedHeaders[_headerNameString]); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void DecodesIndexedHeaderField_DynamicTable_ReferencedEntryRemovedOnInsertion() | |||
There was a problem hiding this comment.
@amcasey just added this test in #57221. It should have been sync'd the other way - to dotnet/runtime.
@amcasey - would it be better if you first added tests like this to dotnet/runtime, and then let the code flow to aspnetcore?
cc @Tratcher - is this the preferred way to add tests to these shared files?
|
@javiercn please don't merge these sync PRs without checking with whoever made the original change to figure out which way the sync should go. The default is runtime -> aspnetcore, but sometimes we need to go the other way instead. @eerhardt @amcasey Making changes in either repo is fine, but to sync aspnetcore -> runtime you need to trigger it manually: |
|
It seems easier to remember to make the changes in runtime than to run that action every time, so I'll try doing it that way next time. Sorry for the confusion. Edit: I kicked off the workflow |
|
Reverse PR is dotnet/runtime#106773 |
This PR was automatically generated to sync shared code changes from runtime. Fixes #18943