This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
FileStream should not truncate files when opening fails. #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @poizan42. This seems reasonable. Could you put up a PR for one or more tests in corefx that'll fail before this change and succeed after? cc: @JeremyKuhne |
|
Also, is there any measurable perf difference that stems from having the extra call? |
poizan42
added a commit
to poizan42/corefx
that referenced
this pull request
Sep 20, 2017
|
PR for test: dotnet/corefx#24163 |
poizan42
added a commit
to poizan42/corefx
that referenced
this pull request
Sep 20, 2017
poizan42
added a commit
to poizan42/corefx
that referenced
this pull request
Sep 20, 2017
pjanotti
approved these changes
Sep 20, 2017
|
Thanks for your contribution @poizan42. |
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Oct 3, 2017
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate at the end of initialization if required by the filemode instead. Fixes dotnet/corefx#24081