This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Setting binary serialization culture to invariant to avoid test machine diffs #23391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
OSXSerialization
branch
from
49cdd53 to
b88647a
Compare
|
The changed diffs now show exactly which types are dependent on the culture:
|
tarekgh
approved these changes
Aug 18, 2017
|
@dotnet-bot test this please |
|
Thank you Dan for merging yesterday. Because of that we now have accurate results 👍 |
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Aug 24, 2017
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Aug 24, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…test machines (dotnet/corefx#23391) Commit migrated from dotnet/corefx@c61981d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/21720