This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Make build.cmd more like the build.cmd in CoreCLR repo #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoreFX build.cmd we used as the baseline doesn't need to handle native build and it can afford to just pass it's command line arguments to msbuild verbatim. We won't have that luxury in CoreRT since we have native bits on Windows too. Fix up project.json files to remove the annoying downgrade warning messages in Visual Studio. Change framework in project.json to dotnet, since the other one is apparently ASP.NET specific. Disable the framework resource handling that makes our projects include a phantom Common\src\System\SR.cs file. I'm not fixing everything with this. We are still using a bunch of *.target files designed to build the framework to build a compiler, after all. I don't want to remove that support, because eventually we will also be building pieces of the framework here, but clearly we need a way to distinguish between "this is a compiler assembly" and "this is a framework assembly" at some point.
jkotas
added a commit
that referenced
this pull request
Oct 5, 2015
Make build.cmd more like the build.cmd in CoreCLR repo
Open
akrisiun
pushed a commit
to akrisiun/corert
that referenced
this pull request
Dec 1, 2018
Bump to latest upstream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native build and it can afford to just pass it's command line arguments
to msbuild verbatim. We won't have that luxury in CoreRT since we have
native bits on Windows too.
messages in Visual Studio.
apparently ASP.NET specific.
a phantom Common\src\System\SR.cs file.
I'm not fixing everything with this. We are still using a bunch of
*.target files designed to build the framework to build a compiler,
after all. I don't want to remove that support, because eventually we
will also be building pieces of the framework here, but clearly we need
a way to distinguish between "this is a compiler assembly" and "this is
a framework assembly" at some point.