This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Initial hookup of GC code to MRT code #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase away the "Merge branch 'master' into integrate-gc " commits? |
|
Done |
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
| // | ||
|
|
||
| //------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
This file should live in gc\env or gc\sample because of the definitions in this file are runtime specific. It would break ability to share the exact same GC sources with CLR/CoreCLR.
There was a problem hiding this comment.
I think that the right setup should be:
- Move gc\env\gcenv.h -> gc\sample\gcenv.h
- Create a new own copy of gcenv.h for CoreRT runtime that can be modified at will
- Factor useful definitions from gc\sample\gcenv.h into smaller files under gc\env* that the runtime-specific environments may choose to use. E.g. this one can be gcenv.object.h.
|
LGTM otherwise |
|
LGTM |
…not yet hooked up.
Provide specialized gcenv.h for CoreRT. Some refactoring of related gcenv stuff. Wire up finalizer code. Add runtime-specific scanning code.
smosier
added a commit
that referenced
this pull request
Oct 14, 2015
Initial hookup of GC code to MRT code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint of GC-to-MRT hookup. These changes allow us to build a .lib on windows using an on-the-side VS project. There are still issues with the two separate definitions of various things like Thread, ThreadStore, and a few others, so the .lib isn't usable just yet.