Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 on using static directive doesn't open the correct help page #43899

Closed
jhinder opened this issue Apr 27, 2023 · 7 comments
Closed

F1 on using static directive doesn't open the correct help page #43899

jhinder opened this issue Apr 27, 2023 · 7 comments
Assignees
Labels
okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@jhinder
Copy link

jhinder commented Apr 27, 2023

Version Used: VS 17.6 P5

Steps to Reproduce:
Press F1 while the caret is on the keywords using or static.

using static System.Console;

Expected Behavior:
In both cases the help document for using directives is opened, which has a section on the static modifier.

Actual Behavior:
In both cases the "No F1 help match was found" page is opened.


Associated WorkItem - 360315

@BillWagner
Copy link
Member

BillWagner commented Apr 28, 2023

I checked the docs source, and those tokens should resolve as follows:

static => https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/keywords/static.md?plain=1#L6-L7
using => https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/keywords/using.md?plain=1#L6

LMK if the keyword tokens should change.

@jhinder
Copy link
Author

jhinder commented Apr 28, 2023

The C# help service returns the term using-static_CSharpKeyword for both tokens of a using static directive. https://github.com/dotnet/roslyn/blob/4cc1b4e/src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContextService.cs#L422-L429

Apparently that doesn't map to any page in the docs, right?

@mavasani
Copy link
Contributor

Assigning to @arkalyanms, similar to #43915, to help identify and assign to the appropriate owner(s) for F1 help.

@ghost
Copy link

ghost commented Oct 30, 2023

Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it.

@ghost
Copy link

ghost commented Nov 9, 2023

Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it.

@CyrusNajmabadi CyrusNajmabadi reopened this Nov 9, 2023
@arunchndr arunchndr added this to the Backlog milestone Oct 28, 2024
@CyrusNajmabadi CyrusNajmabadi removed this from the Backlog milestone Nov 23, 2024
@CyrusNajmabadi
Copy link
Member

@BillWagner i'm moving this to docs. We need a link setup so that using-static_CSharpKeyword goes to the right help page. thanks!

@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Dec 7, 2024
@CyrusNajmabadi CyrusNajmabadi transferred this issue from dotnet/roslyn Dec 7, 2024
@BillWagner BillWagner self-assigned this Dec 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Dec 9, 2024
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 6, 2025
@BillWagner BillWagner added 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed ⌚ Not Triaged Not triaged labels Jan 6, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Jan 7, 2025
@BillWagner BillWagner moved this from 🔖 Ready to 🏗 In progress in dotnet/docs January 2025 sprint project Jan 27, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 27, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 27, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 27, 2025
@BillWagner BillWagner moved this from 🏗 In progress to 👀 In review in dotnet/docs January 2025 sprint project Jan 27, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 27, 2025
@BillWagner
Copy link
Member

Fixed in #44540

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs January 2025 sprint project Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Development

No branches or pull requests

5 participants