Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 on global keyword of a global using directive opens the wrong help page #43915

Open
jhinder opened this issue Apr 27, 2023 · 7 comments · Fixed by dotnet/roslyn#76327
Open
Assignees
Labels
⌚ Not Triaged Not triaged

Comments

@jhinder
Copy link

jhinder commented Apr 27, 2023

Version Used: VS 17.6 P5

Steps to Reproduce:
Press F1 on the global keyword.

global using System;

Expected Behavior:
The help page for using directives is opened, which has a section on the global modifier.

Actual Behavior:
The help page for the namespace alias operator is opened, which explains the usage of global as a namespace alias.

@mavasani
Copy link
Contributor

@arkalyanms do we know which team/dev owns the F1 help experience?

@mavasani
Copy link
Contributor

Arun - assigning to you to help re-assign to the appropriate owners/repo/

@mavasani
Copy link
Contributor

Tagging @BillWagner who might know

@arunchndr
Copy link
Member

@olegtk is this on the Editor side?

@CyrusNajmabadi
Copy link
Member

@arkalyanms this is on our side. We own the "help label" that is produced, and the doc team owns tying that label to a particular page that explains it.

@olegtk
Copy link

olegtk commented Oct 23, 2023

F1 command is owned by VS Shell, but many components contribute key/values (called "language context") that eventually comprise the URL that is being open in browser. I see the URL in this case is
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/namespace-alias-qualifier?devlangs=csharp&f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(global_CSharpKeyword)%3Bk(TargetFrameworkMoniker-.NETFramework%2CVersion%253Dv4.7.2)%3Bk(DevLang-csharp)%26rd%3Dtrue

Notice "global_CSharpKeyword". But the page you want it to open has using_CSharpKeyword tag:
https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/keywords/using-directive.md

So I guess you need to update either of these to match.

@arunchndr arunchndr added this to the Backlog milestone Oct 28, 2024
@CyrusNajmabadi CyrusNajmabadi removed this from the Backlog milestone Nov 23, 2024
@CyrusNajmabadi CyrusNajmabadi reopened this Dec 9, 2024
@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Dec 9, 2024
@CyrusNajmabadi CyrusNajmabadi transferred this issue from dotnet/roslyn Dec 9, 2024
@CyrusNajmabadi
Copy link
Member

Moving to docs. we now pass global-using_CSharpKeyword to the docs system.

@BillWagner BillWagner removed the Pri3 label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌚ Not Triaged Not triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants