Perf: Skip visiting table inside ColumnExpression

dotnet · Sep 5, 2019 · 8b2644f · 8b2644f
1 parent 7fa7c03
commit 8b2644f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/EFCore.Relational/Query/Internal/NullSemanticsRewritingExpressionVisitor.cs b/src/EFCore.Relational/Query/Internal/NullSemanticsRewritingExpressionVisitor.cs
@@ -73,10 +73,9 @@ private SqlConstantExpression VisitSqlConstantExpression(SqlConstantExpression s
 
         private ColumnExpression VisitColumnExpression(ColumnExpression columnExpression)
         {
-            var newTable = (TableExpressionBase)Visit(columnExpression.Table);
             _isNullable = columnExpression.IsNullable;
 
-            return columnExpression.Update(newTable);
+            return columnExpression;
         }
 
         private SqlParameterExpression VisitSqlParameterExpression(SqlParameterExpression sqlParameterExpression)

diff --git a/src/EFCore.Relational/Query/SqlExpressions/ColumnExpression.cs b/src/EFCore.Relational/Query/SqlExpressions/ColumnExpression.cs
@@ -50,13 +50,7 @@ private ColumnExpression(string name, TableExpressionBase table, Type type, Rela
         public TableExpressionBase Table { get; }
         public bool IsNullable { get; }
 
-        protected override Expression VisitChildren(ExpressionVisitor visitor)
-            => Update((TableExpressionBase)visitor.Visit(Table));
-
-        public virtual ColumnExpression Update(TableExpressionBase table)
-            => table != Table
-                ? new ColumnExpression(Name, table, Type, TypeMapping, IsNullable)
-                : this;
+        protected override Expression VisitChildren(ExpressionVisitor visitor) => this;
 
         public ColumnExpression MakeNullable()
             => new ColumnExpression(Name, Table, Type.MakeNullable(), TypeMapping, true);