Temporarily dispose commands synchronously

Seems to cause EntryPointNotFoundException somehow... We're also not disposing commands asynchronously elsewhere at the moment.
dotnet · Apr 22, 2020 · b4703a7 · b4703a7
1 parent 550833b
commit b4703a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerTransaction.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerTransaction.cs
@@ -42,7 +42,7 @@ public override void Save(string savepointName)
         /// <inheritdoc />
         public override async Task SaveAsync(string savepointName, CancellationToken cancellationToken = default)
         {
-            await using var command = Connection.DbConnection.CreateCommand();
+            using var command = Connection.DbConnection.CreateCommand();
             command.Transaction = _dbTransaction;
             command.CommandText = "SAVE TRANSACTION " + savepointName;
             await command.ExecuteNonQueryAsync(cancellationToken);
@@ -60,7 +60,7 @@ public override void Rollback(string savepointName)
         /// <inheritdoc />
         public override async Task RollbackAsync(string savepointName, CancellationToken cancellationToken = default)
         {
-            await using var command = Connection.DbConnection.CreateCommand();
+            using var command = Connection.DbConnection.CreateCommand();
             command.Transaction = _dbTransaction;
             command.CommandText = "ROLLBACK TRANSACTION " + savepointName;
             await command.ExecuteNonQueryAsync(cancellationToken);

diff --git a/src/EFCore.Sqlite.Core/Storage/Internal/SqliteTransaction.cs b/src/EFCore.Sqlite.Core/Storage/Internal/SqliteTransaction.cs
@@ -42,7 +42,7 @@ public override void Save(string savepointName)
         /// <inheritdoc />
         public override async Task SaveAsync(string savepointName, CancellationToken cancellationToken = default)
         {
-            await using var command = Connection.DbConnection.CreateCommand();
+            using var command = Connection.DbConnection.CreateCommand();
             command.Transaction = _dbTransaction;
             command.CommandText = "SAVEPOINT " + savepointName;
             await command.ExecuteNonQueryAsync(cancellationToken);
@@ -60,7 +60,7 @@ public override void Rollback(string savepointName)
         /// <inheritdoc />
         public override async Task RollbackAsync(string savepointName, CancellationToken cancellationToken = default)
         {
-            await using var command = Connection.DbConnection.CreateCommand();
+            using var command = Connection.DbConnection.CreateCommand();
             command.Transaction = _dbTransaction;
             command.CommandText = "ROLLBACK TO " + savepointName;
             await command.ExecuteNonQueryAsync(cancellationToken);
@@ -78,7 +78,7 @@ public override void Release(string savepointName)
         /// <inheritdoc />
         public override async Task ReleaseAsync(string savepointName, CancellationToken cancellationToken = default)
         {
-            await using var command = Connection.DbConnection.CreateCommand();
+            using var command = Connection.DbConnection.CreateCommand();
             command.Transaction = _dbTransaction;
             command.CommandText = "RELEASE " + savepointName;
             await command.ExecuteNonQueryAsync(cancellationToken);